Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

category::form_tree() doesn't close <li> and <ul> tags. #905

Closed
jetherton opened this issue Oct 23, 2012 · 3 comments
Closed

category::form_tree() doesn't close <li> and <ul> tags. #905

jetherton opened this issue Oct 23, 2012 · 3 comments
Assignees
@jetherton
Labels
Bug P2 - Normal

Comments

@jetherton
Copy link
Collaborator

Not only are the closing tags for

  • completely left out for both parent and child levels, the logic of the function is wrong, and thus will never close the last
      tag either. Good thing modern browsers are so smart.

    		•
    @ghost ghost assigned jetherton Oct 23, 2012
    jetherton added a commit that referenced this issue Oct 23, 2012
    @jetherton
    This closes issue #905 - category::form_tree() doesn't close <li> and…
    d4d4087 
    … <ul> tags. I added the missing </li> tags and fixed the program logic so the last </ul> tag is also added. I also made the output HTML pretty. It made debugging a lot easier.
    @jetherton
    Copy link
    Collaborator Author

    Closed.

    rjmackay added a commit to rjmackay/Ushahidi_Web that referenced this issue Oct 23, 2012
    @rjmackay
    Readd category tree classes from ushahidi#871
    4502d61 
    These were removed by ushahidi#905. Now leaving in both classes and IDs
Also removing windows style new lines
    @rjmackay
    Copy link
    Contributor

    Good catch. Somehow I haven't missed that all the times I've messed with the category helper lately.

    However you also reverted the change to add classes to category columns instead of IDs.. just readded that.
    Also remove the windows style new lines, as most of the code base is all unix new lines

    @jetherton
    Copy link
    Collaborator Author

    Thanks for catching that. I was working on a 2.5 install that had zero
    tolerance for malformed HTML, so I probably copied something over with
    out realizing the error.

    On 10/23/2012 02:20 PM, Robbie MacKay wrote:

    Good catch. Somehow I haven't missed that all the times I've messed
    with the category helper lately.

    However you also reverted the change to add classes to category
    columns instead of IDs.. just readded that.

    —
    Reply to this email directly or view it on GitHub
    #905 (comment).

    rjmackay pushed a commit to labb/Ushahidi_Web that referenced this issue Dec 12, 2012
    @jetherton @rjmackay
    This closes issue ushahidi#905 - category::form_tree() doesn't close …
    5b9f94c 
    …<li> and <ul> tags. I added the missing </li> tags and fixed the program logic so the last </ul> tag is also added. I also made the output HTML pretty. It made debugging a lot easier.
    rjmackay added a commit to labb/Ushahidi_Web that referenced this issue Dec 12, 2012
    @rjmackay
    Readd category tree classes from ushahidi#871
    432d2dd 
    These were removed by ushahidi#905. Now leaving in both classes and IDs
Also removing windows style new lines
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @jetherton jetherton

    Labels
    Bug P2 - Normal
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @rjmackay @jetherton