Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme enhancement: phone numbers (Default Theme) #879

Closed
lbell opened this issue Oct 9, 2012 · 3 comments
Closed

Theme enhancement: phone numbers (Default Theme) #879

lbell opened this issue Oct 9, 2012 · 3 comments
Labels
Milestone

Comments

@lbell
Copy link

lbell commented Oct 9, 2012

Simple formatting:

themes/default/main/views/layout.php line 171:

change from:

<strong><?php echo $phone ; ?></strong>

to:

<br /><strong><?php echo $phone ; ?></strong>

is one possible way to clean up the run-on phone numbers if there are multiples

@rjmackay
Copy link
Contributor

rjmackay commented Oct 9, 2012

@lbell haven't had a detailed look at the issue. But possibly some css tweaks to change the word wrap too?
Could you add a screen shot?

If you know how, it'd be awesome if you could send a pull request with the changes

@lbell
Copy link
Author

lbell commented Oct 10, 2012

Hi @rjmackay -- here's what I'm talking about

Before:

before

and After:

after

As for pull requests - I'm not quite set up for that -- but once I get deeper into the tweaking, I'll get it going. Thanks!

rjmackay added a commit that referenced this issue Oct 10, 2012
Also change <strong> tagging on phone numbers to match other ways to report
@rjmackay
Copy link
Contributor

Looks good. Commited the change to develop and closing this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants