Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract and optimize default theme #550

Open
rjmackay opened this issue Jun 6, 2012 · 1 comment
Open

Abstract and optimize default theme #550

rjmackay opened this issue Jun 6, 2012 · 1 comment
Labels
Feature P2 - Normal

Comments

@rjmackay
Copy link
Contributor

rjmackay commented Jun 6, 2012

  • Splitting out default theme style.css into base.css with absolute minimum and style.css with the default theme styles
  • Allow overriding default theme css/js Allow themes to override default theme css/js files #301
  • Move media/css and media/js files into themes where possible
  • Refactor code that drives themes
  • Possibly allow themes to inherit from other themes (and split default into a base and default theme)
@rjmackay
Copy link
Contributor Author

rjmackay commented Jun 6, 2012

Related issues: #338 #301

rjmackay added a commit that referenced this issue Oct 28, 2012
@rjmackay
Refactor plugins helper, plugin controller and theme controller to sh…
72cb5d5 
…are code. Issue #550

* Create addon helper
* Move directory search and readme.txt parsing to addon helper
* Move plugin db sync to plugin helper
* Update controllers and views to match
* Handle default like any other theme (add readme.txt to default theme)
* Include unit tests for new addon helper
* Remove unused addon::config_load()
@rjmackay rjmackay mentioned this issue Dec 3, 2012
Merged
rjmackay added a commit to rjmackay/Ushahidi_Web that referenced this issue Dec 10, 2012
@rjmackay
Rename rapidxwpr div class to wrapper - since thats what it is ushahi…
f2e4f71 
…di#550

* Fix other themes for renaming rapidxwpr to wrapper ushahidi#550
rjmackay added a commit to rjmackay/Ushahidi_Web that referenced this issue Dec 10, 2012
@rjmackay
Move pngFix into global.js and remove runScheduler function ushahidi#550
27d0645 


* pngFix can be run everywhere anyway.
* runScheduler was never being called
rjmackay added a commit to rjmackay/Ushahidi_Web that referenced this issue Dec 10, 2012
@rjmackay
Switch themes to only include a limited set of CSS files by default u…
be48891 
…shahidi#550

* Allow themes to specify addition css/js files to include in readme.txt
* Only include _default.css, style.css or THEMENAME.css by default
* Update existing themes to specify JS files
rjmackay added a commit to rjmackay/Ushahidi_Web that referenced this issue Dec 10, 2012
@rjmackay
Share images between frontend and admin where possible ushahidi#550
0c1d810 
* Also removing some unused images
* Remove duplicate images
* Remove duplicate jquery.timeago JS in ci_cumulus theme
rjmackay added a commit to rjmackay/Ushahidi_Web that referenced this issue Dec 10, 2012
@rjmackay
Move admin ie CSS in to media/css/ie6.css ushahidi#550
1cc5bfe 
Conflicts:

	application/views/admin/layout.php
rjmackay added a commit to labb/Ushahidi_Web that referenced this issue Dec 12, 2012
@rjmackay
Allow closing the reports date filter after its opened ushahidi#550
5b99981
rjmackay added a commit to labb/Ushahidi_Web that referenced this issue Dec 12, 2012
@rjmackay
Move lots of inline CSS in default theme into css files ushahidi#550
6ec95ce 
* Make a reasonable attempt to do the same in other themes too

Conflicts:

	themes/default/views/main/layout.php
	themes/unicorn/views/main/layout.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature P2 - Normal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rjmackay