-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate Reliance on External Resources (ie: Google for JQuery) #265
Comments
Does this mean you're also getting rid of the call to tracker.ushahidi.com? It's another unnecessary call to a 3rd party site that collects information and tracks users. |
You can turn that off if you want to. |
Found this: application/libraries/Themes.php: $core_js .= html::script("https://ajax.googleapis.com/ajax/libs/jqueryui/1.8.13/jquery-ui.min.js", true); |
I probably won't be doing this so I'm going to unassign myself. If anyone wants to take this up, I'll be a cheerleader. |
Doing this along with #338 |
I did it. I can give you a pull request if you want. On Thu, Jun 28, 2012 at 8:02 PM, Robbie MacKay <
Aaron Huslage |
@huslage Was there anything other than jquery ui?? drop a pull request but I've been messing around a lot with the js/css loading code so I'll probably rework it in with my other changes. |
* Replace jquery.ui.min.js with version including accordion Previously only included features used in the admin. * No longer using the google CDN for this as per ushahidi#365 * Previously the admin used its own jquery UI, now both admin and frontend use the same version
* Replace jquery.ui.min.js with version including accordion Previously only included features used in the admin. * No longer using the google CDN for this as per ushahidi#365 * Previously the admin used its own jquery UI, now both admin and frontend use the same version
Should be covered in 2.7 |
We have a number of javascript files that are hosted by other services. This is not ideal for a number of reasons. If Google is blocked in China and there's a deployment in China, then the site may not work properly without JQuery installed. Also, if you do development locally on a poor or nonexistent connection, then you cannot get those resources, making things slow / difficult. Finally, Google could potentially be collecting information and tracking users based on downloads of these files.
TASK:
The text was updated successfully, but these errors were encountered: