Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate Reliance on External Resources (ie: Google for JQuery) #265

Closed
brianherbert opened this issue Feb 20, 2012 · 8 comments
Closed

Comments

@brianherbert
Copy link
Contributor

We have a number of javascript files that are hosted by other services. This is not ideal for a number of reasons. If Google is blocked in China and there's a deployment in China, then the site may not work properly without JQuery installed. Also, if you do development locally on a poor or nonexistent connection, then you cannot get those resources, making things slow / difficult. Finally, Google could potentially be collecting information and tracking users based on downloads of these files.

TASK:

  • Store external resources locally and default to calling them locally wherever it makes sense (mostly just jquery).
@ghost ghost assigned brianherbert Feb 20, 2012
@jetherton
Copy link
Collaborator

Does this mean you're also getting rid of the call to tracker.ushahidi.com? It's another unnecessary call to a 3rd party site that collects information and tracks users.

@brianherbert
Copy link
Contributor Author

You can turn that off if you want to.

@huslage
Copy link

huslage commented Apr 2, 2012

Found this:

application/libraries/Themes.php: $core_js .= html::script("https://ajax.googleapis.com/ajax/libs/jqueryui/1.8.13/jquery-ui.min.js", true);

@brianherbert
Copy link
Contributor Author

I probably won't be doing this so I'm going to unassign myself. If anyone wants to take this up, I'll be a cheerleader.

@ghost ghost assigned rjmackay Jun 29, 2012
@rjmackay
Copy link
Contributor

Doing this along with #338

@huslage
Copy link

huslage commented Jun 29, 2012

I did it. I can give you a pull request if you want.

On Thu, Jun 28, 2012 at 8:02 PM, Robbie MacKay <
reply@reply.github.com

wrote:

Doing this along with #338


Reply to this email directly or view it on GitHub:
#265 (comment)

Aaron Huslage
http://blog.hact.net
IM: AIM - ahuslage; GTalk - huslage@gmail.com; Skype - huslage

@rjmackay
Copy link
Contributor

@huslage Was there anything other than jquery ui?? drop a pull request but I've been messing around a lot with the js/css loading code so I'll probably rework it in with my other changes.

rjmackay added a commit to rjmackay/Ushahidi_Web that referenced this issue Jul 11, 2012
* Replace jquery.ui.min.js with version including accordion
  Previously only included features used in the admin.
* No longer using the google CDN for this as per ushahidi#365
* Previously the admin used its own jquery UI, now both admin
  and frontend use the same version
rjmackay added a commit to rjmackay/Ushahidi_Web that referenced this issue Dec 10, 2012
* Replace jquery.ui.min.js with version including accordion
  Previously only included features used in the admin.
* No longer using the google CDN for this as per ushahidi#365
* Previously the admin used its own jquery UI, now both admin
  and frontend use the same version
@rjmackay
Copy link
Contributor

rjmackay commented Apr 3, 2013

Should be covered in 2.7

@rjmackay rjmackay closed this as completed Apr 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants