Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Debug Adapter Protocol implementation and connection with Vscode Extension #271

Merged
merged 96 commits into from
Jul 21, 2023
Merged

Added Debug Adapter Protocol implementation and connection with Vscode Extension #271

merged 96 commits into from
Jul 21, 2023

Conversation

yami2200
Copy link
Member

  • Debug Adapter Protocol Implementation :
    • Add / Remove breakpoints
    • Visualize call stacks details
    • Visualize variables values
    • Pause / Step Over / Step in
  • Connection with VScode extension
    • Start debug session with "Run and Debug" blue button or F5 key. (connects to current running and focused REPL)
    • Execute REPL command :set debugging true/false to start or stop debug session

debugger

yami2200 and others added 30 commits June 5, 2023 10:27
@yami2200
feature: add extension command to start terminal with debug parameter
426381b
@yami2200
feature: add first simple DAP implementation
3b19dca
@yami2200
feature: add debug adapter launcher
53dfcb4
@yami2200
refactor: switch debug type from "launch" to "attach"
df6b715
@yami2200
feature: temporary default conf of launch.json
86f21d9
@yami2200
feature: temporary debug adapter launch and connection method with vs…
4f436b2 
…code.
@yami2200
feature: add RascalServices to parse rascal source code to parseTree
d50b6bd
@yami2200
feature: add Rascal EventTrigger to handle suspension events from Ras…
9881605 
…cal.
@yami2200
refactor: edit vscode command to start REPL in debug without running …
137c6ba 
…debugging session.
@yami2200
feature: add --debug argument to Rascal REPL that starts REPL in debu…
0cb6573 
…g mode and launch Debug Adapter.
@yami2200
refactor: remove main method.
8158876
@yami2200
feature: add a first testing implementation for setBreakpointsRequest.
c8cc8eb
@yami2200
refactor: remove parseContents method (moved to RascalServices).
06bb6bc
@yami2200
feature: add singleton BreakpointsManager
aa4d5b9
@yami2200
feature: eventSuspendByBreakpoin now notify the client that debuggee …
961d6e6 
…has stopped.
@yami2200
feature: simple implementation of setBreakpoints request.
a145ea1
@yami2200
feature: add BreakpointInfo class to store idreference and source
1a124a9
@yami2200
feature: add SuspendEndEvent implementation on EventTrigger
e6e97bd
@yami2200
feature: override all requests to keep track of request from vscode, …
282de47 
…add temporary implementation for stackTrace, continue and next.
@yami2200
feature: send process and thread event notification when initialized.
ce65bd8
@yami2200
feature: add method to get the source of breakpoint.
b0f08e3
@yami2200
feature: add evaluator argument to DebugAdapterServer constructor. re…
fb8c23e 
…factor new thread creation in Launcher class.
@yami2200
refactor: start new thread creation in Launcher class.
ab0dd94
@yami2200
feature: first implementation for stackTrace request.
887c33b
@yami2200
fix: add imports, setup capabilities of Debug Adapter Server.
1200087
@yami2200
feature: add stepIn implementation.
bd3b2e4
@yami2200
feature: add Variable Visitor class to get subfields. Tuple, Set, Lis…
4d96928 
…t visits implemented.
@yami2200
feature: add Suspended StateManager to handle stack frames and variab…
6bdeb88 
…le references management.
@yami2200
feature: reset current state of StateManager each time the program is…
f0635dd 
… suspended.
@yami2200
feature: implementation for scope and variables requests.
17d1a74
@jurgenvinju
Copy link
Member

@yami2200 pls pull for the changes in :set debugging semantics and the license headers.

@jurgenvinju
Copy link
Member

@yami2200 is it possible to show the variables of the bottom stack frame? I.e. the REPL's scope? That would be very useful.

@jurgenvinju
Copy link
Member

jurgenvinju commented Jul 18, 2023 •
edited
Loading

I have a stack trace right after (or during( :set debugging true printed in the terminal itself. Still everything works after that.
I used auto-complete on the d<TAB>.

rascal>Jul 18, 2023 9:49:55 AM org.eclipse.lsp4j.jsonrpc.RemoteEndpoint fallbackResponseError
SEVERE: Internal error: Parse error
at file:///Users/jurgenv/git/rascal/src/org/rascalmpl/repl/BaseRascalREPL.java offset=0 length=1 begin=1:0 end=1:1
java.util.concurrent.CompletionException: Parse error
at file:///Users/jurgenv/git/rascal/src/org/rascalmpl/repl/BaseRascalREPL.java offset=0 length=1 begin=1:0 end=1:1
        at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:314)
        at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:319)
        at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1702)
        at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1692)
        at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
        at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
        at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
        at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
        at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:183)
Caused by: Parse error
at file:///Users/jurgenv/git/rascal/src/org/rascalmpl/repl/BaseRascalREPL.java offset=0 length=1 begin=1:0 end=1:1
        at org.rascalmpl.parser.gtd.SGTDBF.parse(SGTDBF.java:1197)
        at org.rascalmpl.parser.gtd.SGTDBF.parse(SGTDBF.java:1235)
        at org.rascalmpl.parser.gtd.SGTDBF.parse(SGTDBF.java:1240)
        at org.rascalmpl.parser.gtd.SGTDBF.parse(SGTDBF.java:1252)
        at org.rascalmpl.vscode.lsp.util.RascalServices.parseRascalModule(RascalServices.java:42)
        at org.rascalmpl.vscode.lsp.dap.RascalDebugAdapter.lambda$setBreakpoints$1(RascalDebugAdapter.java:145)
        at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1700)
        ... 6 more

Jul 18, 2023 9:49:55 AM org.eclipse.lsp4j.jsonrpc.RemoteEndpoint fallbackResponseError
SEVERE: Internal error: Parse error
at file:///Users/jurgenv/git/rascal/src/org/rascalmpl/library/Prelude.java offset=797 length=1 begin=17:0 end=17:1
java.util.concurrent.CompletionException: Parse error
at file:///Users/jurgenv/git/rascal/src/org/rascalmpl/library/Prelude.java offset=797 length=1 begin=17:0 end=17:1
        at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:314)
        at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:319)
        at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1702)
        at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1692)
        at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
        at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
        at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
        at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
        at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:183)
Caused by: Parse error
at file:///Users/jurgenv/git/rascal/src/org/rascalmpl/library/Prelude.java offset=797 length=1 begin=17:0 end=17:1
        at org.rascalmpl.parser.gtd.SGTDBF.parse(SGTDBF.java:1197)
        at org.rascalmpl.parser.gtd.SGTDBF.parse(SGTDBF.java:1235)
        at org.rascalmpl.parser.gtd.SGTDBF.parse(SGTDBF.java:1240)
        at org.rascalmpl.parser.gtd.SGTDBF.parse(SGTDBF.java:1252)
        at org.rascalmpl.vscode.lsp.util.RascalServices.parseRascalModule(RascalServices.java:42)
        at org.rascalmpl.vscode.lsp.dap.RascalDebugAdapter.lambda$setBreakpoints$1(RascalDebugAdapter.java:145)
        at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1700)
        ... 6 more

Jul 18, 2023 9:49:55 AM org.eclipse.lsp4j.jsonrpc.RemoteEndpoint fallbackResponseError
SEVERE: Internal error: Parse error
at file:///Users/jurgenv/git/rascal/src/org/rascalmpl/values/parsetrees/SymbolAdapter.java offset=699 length=1 begin=16:0 end=16:1
java.util.concurrent.CompletionException: Parse error
at file:///Users/jurgenv/git/rascal/src/org/rascalmpl/values/parsetrees/SymbolAdapter.java offset=699 length=1 begin=16:0 end=16:1
        at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:314)
        at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:319)
        at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1702)
        at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1692)
        at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
        at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
        at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
        at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
        at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:183)
Caused by: Parse error
at file:///Users/jurgenv/git/rascal/src/org/rascalmpl/values/parsetrees/SymbolAdapter.java offset=699 length=1 begin=16:0 end=16:1
        at org.rascalmpl.parser.gtd.SGTDBF.parse(SGTDBF.java:1197)
        at org.rascalmpl.parser.gtd.SGTDBF.parse(SGTDBF.java:1235)
        at org.rascalmpl.parser.gtd.SGTDBF.parse(SGTDBF.java:1240)
        at org.rascalmpl.parser.gtd.SGTDBF.parse(SGTDBF.java:1252)
        at org.rascalmpl.vscode.lsp.util.RascalServices.parseRascalModule(RascalServices.java:42)
        at org.rascalmpl.vscode.lsp.dap.RascalDebugAdapter.lambda$setBreakpoints$1(RascalDebugAdapter.java:145)
        at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1700)
        ... 6 more

Jul 18, 2023 9:49:55 AM org.eclipse.lsp4j.jsonrpc.RemoteEndpoint fallbackResponseError
SEVERE: Internal error: Parse error
at file:///Users/jurgenv/git/rascal/src/org/rascalmpl/types/NonTerminalType.java offset=611 length=1 begin=14:0 end=14:1
java.util.concurrent.CompletionException: Parse error
at file:///Users/jurgenv/git/rascal/src/org/rascalmpl/types/NonTerminalType.java offset=611 length=1 begin=14:0 end=14:1
        at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:314)
        at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:319)
        at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1702)
        at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1692)
        at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
        at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
        at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
        at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
        at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:183)
Caused by: Parse error
at file:///Users/jurgenv/git/rascal/src/org/rascalmpl/types/NonTerminalType.java offset=611 length=1 begin=14:0 end=14:1
        at org.rascalmpl.parser.gtd.SGTDBF.parse(SGTDBF.java:1197)
        at org.rascalmpl.parser.gtd.SGTDBF.parse(SGTDBF.java:1235)
        at org.rascalmpl.parser.gtd.SGTDBF.parse(SGTDBF.java:1240)
        at org.rascalmpl.parser.gtd.SGTDBF.parse(SGTDBF.java:1252)
        at org.rascalmpl.vscode.lsp.util.RascalServices.parseRascalModule(RascalServices.java:42)
        at org.rascalmpl.vscode.lsp.dap.RascalDebugAdapter.lambda$setBreakpoints$1(RascalDebugAdapter.java:145)
        at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1700)
        ... 6 more


cancelled

@yami2200
fix: improve and secure serverSocket multithread access.
c348818
@yami2200
refactor: declare map variables with base interface.
bc0b803
@yami2200
refactor: scope and frames creation into functions. + small code impr…
da710d5 
…ovements.
@yami2200
docs: add documentation to explain the delay when terminating the deb…
b0a99b6 
…ug session.
@yami2200
docs: update event trigger unsupportedOperation messages
70ce1c5
@yami2200
fix: add type verification for SuspendByBreakpointEvent parameter data.
23aa2fc
@yami2200
fix: secure multi threads usage of SuspendedState class
61ec970
@yami2200
refactor: improve small details for VariableSubfieldsVisitor, fix doc…
c06b699 
… comment for VariableUtils
@yami2200
refactor: avoid copying maps and sets when visiting with VariableSubf…
1d3e8b5 
…ieldsVisitor
@yami2200
perf: improve performance and multithread usage of BreakpointsCollection
7994682
@yami2200
refactor: remove .idea from global gitignore
a96bd35
@yami2200
refactor: replace file content reader logic with Prelude.consumeInput…
28df99b 
…Stream()
@yami2200
refactor: function resolveDebugConfiguration of RascalDebugConfigurat…
03e7dd8 
…ionProvider.ts
@yami2200
refactor: change debug labels to "Rascal debugger"
b2bc254
@yami2200
refactor: add regex to handle command :set debugging
9600fbb
@yami2200
feature: improve libraries path transformation between vscode and ras…
0bb3380 
…cal. add support for all schemes.
@yami2200
refactor: improve variable naming
cd28662
@yami2200
fix: add null verification for getDisplayString of RascalVariableUtils
b6271f7
@yami2200
fix: fix parseError issue by verifying that breakpoints are set in a …
d769d9b 
…rascal file.
@yami2200
style: change process name sent to debug client.
412a2fd
@yami2200
style: removed unused argument ESLint warning
3100c0d
@DavyLandman DavyLandman merged commit da1ac36 into usethesource:main Jul 21, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavyLandman DavyLandman DavyLandman left review comments

@jurgenvinju jurgenvinju jurgenvinju requested changes

Assignees

@jurgenvinju jurgenvinju

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yami2200 @jurgenvinju @DavyLandman