Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSPTerminalWrapper can remove fix wrt watching logical locations #436

Closed
jurgenvinju opened this issue Aug 30, 2024 · 0 comments · Fixed by #455
Closed

LSPTerminalWrapper can remove fix wrt watching logical locations #436

jurgenvinju opened this issue Aug 30, 2024 · 0 comments · Fixed by #455
Labels
bug Something isn't working

Comments

@jurgenvinju
Copy link
Member

jurgenvinju commented Aug 30, 2024

In LSPTerminalWrapper.java:

for (IValue srcPath : pcfg.getSrcs()) {
                            ISourceLocation path = (ISourceLocation)srcPath;
                            evaluator.addRascalSearchPath(path);
                            // since the watch function in rascal only works on resolved paths
                            // we have to resolve the path, until that issue is remedied.
                            // see issue: https://github.com/usethesource/rascal/issues/1884
                            ISourceLocation resolvedPath = safeResolve(reg, path);
                            reg.watch(resolvedPath, true, d -> sourceLocationChanged(resolvedPath, d));
}

usethesource/rascal#1884 has been solved in 2023 so I think we now have broken behavior because we did not follow up on this comment yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant