Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #953 #955

Merged
merged 5 commits into from
Apr 5, 2019
Merged

Fix #953 #955

merged 5 commits into from
Apr 5, 2019

Conversation

lcharette
Copy link
Member

@lcharette lcharette commented Apr 5, 2019

Fix for issue #953

@lcharette lcharette added this to the 4.2.x milestone Apr 5, 2019
@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #955 into hotfix will increase coverage by 0.06%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff              @@
##             hotfix     #955      +/-   ##
============================================
+ Coverage     36.76%   36.82%   +0.06%     
+ Complexity     2122     2121       -1     
============================================
  Files           158      158              
  Lines          7216     7212       -4     
============================================
+ Hits           2653     2656       +3     
+ Misses         4563     4556       -7
Impacted Files Coverage Δ Complexity Δ
...nkles/account/src/Controller/AccountController.php 0% <0%> (ø) 84 <0> (-1) ⬇️
app/sprinkles/account/src/Account/Registration.php 63.63% <100%> (+3.4%) 25 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eb889d...fb6da3a. Read the comment docs.

@lcharette lcharette merged commit e82129f into hotfix Apr 5, 2019
@lcharette lcharette deleted the hotfix-issue#953 branch April 5, 2019 02:10
@lcharette lcharette restored the hotfix-issue#953 branch April 7, 2019 23:48
@lcharette lcharette deleted the hotfix-issue#953 branch April 7, 2019 23:48
@lcharette lcharette modified the milestones: 4.2.x, 4.2.1 Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant