Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for PostgreSQL setup #745

Merged
merged 2 commits into from Jul 11, 2017
Merged

Fix for PostgreSQL setup #745

merged 2 commits into from Jul 11, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jun 26, 2017

Stops charset errors at setup.

Stops charset errors at setup.
@lcharette lcharette self-assigned this Jun 26, 2017
@lcharette lcharette added bakery Related to the Bakery feature confirmed bug Something isn't working labels Jun 26, 2017
@lcharette lcharette added this to the 4.1.x milestone Jun 26, 2017
@alexweissman alexweissman added the needs more info Incomplete issue, missing details label Jul 3, 2017
@alexweissman
Copy link
Member

charset should get pulled from the DB config rather than being hardcoded.

@ghost
Copy link
Author

ghost commented Jul 3, 2017

agree - just need bakery to read full config then ;)

@alexweissman
Copy link
Member

Alright, leaving this to you and @lcharette. Taking this off the 4.1.3 roster.

@lcharette
Copy link
Member

Should be good to go. @x00x70 can you test to make sure it still works with Postgre? Should be fine with MySQL ;)

@ghost
Copy link
Author

ghost commented Jul 11, 2017

Tested and confirmed for PostgreSQL 9.6.2

@alexweissman alexweissman merged commit 7326a0d into userfrosting:master Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bakery Related to the Bakery feature confirmed bug Something isn't working needs more info Incomplete issue, missing details
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants