Release 4.6.4 #1197
Merged
Release 4.6.4 #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Back in 2019 a PR was approved to allow "No Group". It looks like the ability for admins to create users without a group was overlooked.
Foreign Key constraint fails when an admin attempts to create a new user
Fix for AccountControllerTest when registration is disabled
PHP 7.4 modified the method_exists behaviour so that it no longer works as required. Alternative is to use is_callable, however this always returns true when __call is present (which it is). Laravel kindly provides a method for checking if a macro exists, so use that instead.
Resolves issue #1195 by adding last stable version 1.6.0 of RocketTheme.
Resolve #1195-Update composer.json
Fix PHP7.4+ compatibility
Handle the case where all roles are removed from a user
Codecov Report
@@ Coverage Diff @@
## master #1197 +/- ##
=========================================
Coverage 70.69% 70.69%
- Complexity 1983 1986 +3
=========================================
Files 173 173
Lines 6903 6907 +4
=========================================
+ Hits 4880 4883 +3
- Misses 2023 2024 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO