Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ufTable pagination issue with tablesorter 2.28.6+ #688

Closed
alexweissman opened this issue Apr 10, 2017 · 11 comments
Closed

ufTable pagination issue with tablesorter 2.28.6+ #688

alexweissman opened this issue Apr 10, 2017 · 11 comments
Labels
compatibility Compatibility issue with other framework, features confirmed bug Something isn't working
Milestone

Comments

@alexweissman
Copy link
Member

This commit fires an additional update event on the Tablesorter object.

However, this seems to break pagination as of Tablesorter 2.28.6+. If you try to advance to the next page, it advances but then quickly flips back to the first page. I believe update is now being fired twice, and that is causing the reset.

@alexweissman alexweissman added the confirmed bug Something isn't working label Apr 10, 2017
@alexweissman alexweissman added this to the 4.0 milestone Apr 10, 2017
@alexweissman alexweissman added the compatibility Compatibility issue with other framework, features label Apr 10, 2017
@alexweissman
Copy link
Member Author

Seems like each new version of Tablesorter introduces some new breaking changes. We need to either lock in a specific version, or keep up with the changes.

@lcharette
Copy link
Member

Got the bug too. Tables doesn't works at all now. +1 for locking version 2.28.6 for now, until we figured out if it's us or them. I can push my change to hotfix for now

lcharette added a commit that referenced this issue Apr 21, 2017
@alexweissman
Copy link
Member Author

Wait, shouldn't we lock at 2.28.5? 2.28.6+ is an inclusive interval ;-)

@lcharette
Copy link
Member

I had no issue with .6? Did you?

@lcharette
Copy link
Member

Ok, just experienced the issue with 2.28.6... Changing the commit to 2.28.5

lcharette added a commit that referenced this issue Apr 22, 2017
@alexweissman
Copy link
Member Author

It looks like v2.28.8 fixes this problem, but then it introduces a new problem: Mottie/tablesorter#1389
😞

So it would seem that we are still stuck with 2.28.5 for now.

@Mottie
Copy link

Mottie commented Apr 23, 2017

Sorry! :( I need to reproduce the issue on my end before I can fix it.

@alexweissman
Copy link
Member Author

No need to apologize! We're all huge fans of tablesorter and appreciate all the time you put into it 👍

@alexweissman alexweissman removed the confirmed bug Something isn't working label Apr 23, 2017
@lcharette lcharette removed their assignment May 4, 2017
@alexweissman alexweissman modified the milestones: 4.x, 4.1.0 May 30, 2017
@alexweissman
Copy link
Member Author

In v4.0, this has been addressed by locking TS to version 2.28.5.

In v4.1, we switch to the widget and rework our system for populating column select menus to eliminate the need for manually triggering a table update. This allows us to upgrade to 2.28.6+.

See 092b7d2.

@alexweissman
Copy link
Member Author

This problem appears to have re-emerged in 4.1. This time, it only seems to happen while there is a filter applied to a column.

@alexweissman alexweissman reopened this Jun 25, 2017
@alexweissman alexweissman added the confirmed bug Something isn't working label Jun 25, 2017
lcharette added a commit that referenced this issue Jun 25, 2017
I don’t know what’s those two lines where about…
@lcharette
Copy link
Member

Note commit 5b77d54 will solve this issue, but it create a new one where the filter-select active option might not be set properly when initially loading the page (reload should still work).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Compatibility issue with other framework, features confirmed bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants