-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ufTable pagination issue with tablesorter 2.28.6+ #688
Comments
Seems like each new version of Tablesorter introduces some new breaking changes. We need to either lock in a specific version, or keep up with the changes. |
Got the bug too. Tables doesn't works at all now. +1 for locking version |
Wait, shouldn't we lock at 2.28.5? 2.28.6+ is an inclusive interval ;-) |
I had no issue with .6? Did you? |
Ok, just experienced the issue with |
It looks like v2.28.8 fixes this problem, but then it introduces a new problem: Mottie/tablesorter#1389 So it would seem that we are still stuck with 2.28.5 for now. |
Sorry! :( I need to reproduce the issue on my end before I can fix it. |
No need to apologize! We're all huge fans of tablesorter and appreciate all the time you put into it 👍 |
In v4.0, this has been addressed by locking TS to version 2.28.5. In v4.1, we switch to the widget and rework our system for populating column select menus to eliminate the need for manually triggering a table update. This allows us to upgrade to 2.28.6+. See 092b7d2. |
This problem appears to have re-emerged in 4.1. This time, it only seems to happen while there is a filter applied to a column. |
Note commit 5b77d54 will solve this issue, but it create a new one where the |
This commit fires an additional
update
event on the Tablesorter object.However, this seems to break pagination as of Tablesorter 2.28.6+. If you try to advance to the next page, it advances but then quickly flips back to the first page. I believe
update
is now being fired twice, and that is causing the reset.The text was updated successfully, but these errors were encountered: