Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The browser locale is not applied automatically #1264

Closed
lcharette opened this issue Sep 15, 2024 · 0 comments
Closed

The browser locale is not applied automatically #1264

lcharette opened this issue Sep 15, 2024 · 0 comments
Assignees
@lcharette
Labels
confirmed bug Something isn't working
Milestone
5.1.x

Comments

@lcharette
Copy link
Member

Affected sprinkle or package

userfrosting/sprinkle-core, userfrosting/sprinkle-account

UserFrosting or package Version

5.1.x

Debug Data

N/A

Chat Discussion (optional)

No response

Description

Continuation from : #1263

The locale is correctly detected from the browser, and set inside SiteLocale first. However the SiteLocale service used in vendor/userfrosting/sprinkle-core/app/src/ServicesProvider/I18nService.php) is not the same instance used in vendor/userfrosting/sprinkle-core/app/src/Middlewares/LocaleMiddleware.php.

Steps To Reproduce

No response
@lcharette lcharette added the confirmed bug Something isn't working label Sep 15, 2024
@lcharette lcharette added this to the 5.1.x milestone Sep 15, 2024
@lcharette lcharette self-assigned this Sep 15, 2024
@lcharette lcharette moved this from Not Started to In Progress in UserFrosting Task Planner Sep 15, 2024
lcharette added a commit to userfrosting/sprinkle-core that referenced this issue Sep 15, 2024
@lcharette
Fix browser locale is not applied correctly
0f2f4df 
userfrosting/UserFrosting#1264
@lcharette lcharette moved this from In Progress to Done in UserFrosting Task Planner Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lcharette lcharette

Labels
confirmed bug Something isn't working
Projects
UserFrosting Task Planner
Status: Done
Milestone
5.1.x
Development

No branches or pull requests
1 participant
@lcharette