add TypeScript #992
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "exec": "bin/link-rs", | ||
| "ext": "js,json,jsx,ts,tsx,scss", | ||
| "verbose": true, | ||
| "watch": [ | ||
| "scss", | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import React from 'react'; | ||
| import type { Meta, StoryObj } from '@storybook/react'; | ||
|
|
||
| import { faPlus } from '@fortawesome/pro-regular-svg-icons'; | ||
|
|
||
| import Button from 'src/Button'; | ||
|
|
||
| import EmptyState from './EmptyState'; | ||
|
|
||
| const meta: Meta<typeof EmptyState> = { | ||
| component: EmptyState, | ||
| title: 'Components/EmptyState', | ||
| }; | ||
|
|
||
| export default meta; | ||
| type Story = StoryObj<typeof EmptyState>; | ||
|
|
||
| export const Default: Story = { | ||
| args: { | ||
| subtitle: 'Launch your first project to start conducting research!', | ||
| title: 'You have no projects', | ||
| } | ||
| }; | ||
|
|
||
| export const PrimaryAction: Story = { | ||
| args: { | ||
| primaryAction: <Button leadingIcon={faPlus} variant="primary">New project</Button>, | ||
| subtitle: 'Launch your first project to start conducting research! Source from a pool of 2.4 million participants to reach nearly any target audience.', | ||
| title: 'You have no projects', | ||
| } | ||
| }; | ||
|
|
||
| export const FullWidth: Story = { | ||
| args: { | ||
| fullWidth: true, | ||
| primaryAction: <Button leadingIcon={faPlus} variant="primary">New project</Button>, | ||
| subtitle: 'Launch your first project to start conducting research! Source from a pool of 2.4 million participants to reach nearly any target audience.', | ||
| title: 'You have no projects', | ||
| } | ||
| }; | ||
|
|
||
| export const MarginTop: Story = { | ||
| args: { | ||
| marginTop: 'sm', | ||
| subtitle: 'Add a new participant segment above', | ||
| title: 'No segments created', | ||
| } | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| import React, { ReactNode } from 'react'; | ||
|
|
||
| import classNames from 'classnames'; | ||
|
|
||
| import { Heading } from '../Heading'; | ||
| import { Text } from '../Text'; | ||
|
|
||
| import './EmptyState.scss'; | ||
|
|
||
| export interface EmptyStateProps { | ||
| className?: string; | ||
| fullWidth?: boolean; | ||
| marginTop?: 'sm' | 'md' | 'lg' | 'none'; | ||
|
There was a problem hiding this comment. nice that TS builds in enums like this There was a problem hiding this comment. Yea this is part of what is going to make TS in the DS incredibly useful over in rails server. FYI this is actually a union of literals, and an enum exactly: https://www.typescriptlang.org/docs/handbook/2/everyday-types.html#union-types But TS does have some awesome enums as well: |
||
| primaryAction?: ReactNode; | ||
| subtitle?: string | ReactNode; | ||
| title?: ReactNode; | ||
| } | ||
|
|
||
| const EmptyState = ({ | ||
| className, | ||
| fullWidth = false, | ||
| marginTop = 'sm', | ||
|
Comment on lines
+21
to
+22
There was a problem hiding this comment. put default props here that used to be on propTypes |
||
| primaryAction, | ||
| subtitle, | ||
| title, | ||
| }: EmptyStateProps) => ( | ||
| <div className={classNames( | ||
| className, | ||
| 'EmptyState', | ||
| marginTop && `EmptyState--margin-top--${marginTop}`, | ||
| )} | ||
| > | ||
| <div className={classNames( | ||
| 'EmptyState__content', | ||
| fullWidth && 'EmptyState--full-width', | ||
| )} | ||
| > | ||
| {title && ( | ||
| <Heading className="EmptyState__title" level={4} size="lg" textAlign="center">{title}</Heading> | ||
| )} | ||
|
|
||
| {subtitle && ( | ||
| <Text className="EmptyState__subtitle" textAlign="center">{subtitle}</Text> | ||
| )} | ||
|
|
||
| {primaryAction && ( | ||
| <div className="EmptyState__actions"> | ||
| <div className="EmptyState__actions__primary-action"> | ||
| {primaryAction} | ||
| </div> | ||
| </div> | ||
| )} | ||
| </div> | ||
| </div> | ||
| ); | ||
|
|
||
| export default EmptyState; | ||
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are react libraries not version-matched? ie. react-dom would also be 16.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not entirely sure. I followed what we were already using on RS, but maybe @kyleshike would know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yikes yea these should be version matched. I guess it hasn't come up because all the react-dom stuff is happening under the hood with
react-railsover in rails-server