Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share tags #4198

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Share tags #4198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fb23b58
Allowing users to share public and protected tags
RoccoSmit Dec 13, 2024
205f52f
Added tag load limits
RoccoSmit Dec 14, 2024
9512def
Moved page limit to request to match existing flow
RoccoSmit Dec 14, 2024
24c6ded
- Aligned feature names to ShareTags
RoccoSmit Dec 14, 2024
4942900
Fix postgres query
RoccoSmit Dec 14, 2024
7938427
Fixed logged out explore tags view
RoccoSmit Dec 14, 2024
f0a52d8
- fixed tags on explore page
RoccoSmit Dec 15, 2024
eefa2b3
Fix go linting issue
RoccoSmit Dec 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions proto/api/v1/memo_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,9 @@ enum MemoView {

// The metadata only view of the memo. Excludes the content/snippet fields.
MEMO_VIEW_METADATA_ONLY = 2;

// The tag centered view of memos. Excludes the content/snippet fields. Allows for shared tags.
MEMO_VIEW_TAGS = 3;
}

message ListMemosRequest {
Expand Down
2 changes: 2 additions & 0 deletions proto/api/v1/workspace_setting_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ message WorkspaceMemoRelatedSetting {
repeated string reactions = 10;
// disable_markdown_shortcuts disallow the registration of markdown shortcuts.
bool disable_markdown_shortcuts = 11;
// share PUBLIC and PROTECTED tags between users.
bool share_tags = 12;
}

message GetWorkspaceSettingRequest {
Expand Down
295 changes: 150 additions & 145 deletions proto/gen/api/v1/memo_service.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

100 changes: 55 additions & 45 deletions proto/gen/api/v1/workspace_setting_service.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading