Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor:(make) dont download binaries if theyre already present #3814

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Sep 30, 2024

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

#3811 fixed some issues symbolic linking, this incorporates some additional checks to prevent needlessly downloading the same versions of these binaries over and over again if they are already present.

Also includes some commands to clean up old lagoon-chart directories and k3dconfig temp files.

@shreddedbacon shreddedbacon marked this pull request as ready for review September 30, 2024 00:41
Makefile Outdated Show resolved Hide resolved
@shreddedbacon shreddedbacon added this to the 2.22.0 milestone Oct 8, 2024
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely!

@tobybellwood tobybellwood merged commit f4f39e2 into main Oct 14, 2024
1 check passed
@shreddedbacon shreddedbacon deleted the more-make-refactoring branch October 14, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants