Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add docs on "additional volumes" #3804

Merged
merged 5 commits into from
Sep 17, 2024
Merged

docs: Add docs on "additional volumes" #3804

merged 5 commits into from
Sep 17, 2024

Conversation

tobybellwood
Copy link
Member

@tobybellwood tobybellwood commented Sep 11, 2024

Adds docs to match updates in other Lagoon systems (https://github.com/uselagoon/build-deploy-tool/milestone/6?closed=1)

[x] Additional Volumes - uselagoon/build-deploy-tool#339
[] Topology Spread - uselagoon/build-deploy-tool#364
[] Path based routing - uselagoon/build-deploy-tool#362
[x] Default BuildKit - uselagoon/build-deploy-tool#360
[] Base Image Refresh - uselagoon/build-deploy-tool#355
[x] Deprecated Images

@shreddedbacon
Copy link
Member

shreddedbacon commented Sep 11, 2024

On the additional volumes work, i'm wondering if it is worth mentioning that the -persistent types that support additional volumes are not really required anymore, and that using the additional volumes is the recommended way forward for new services?

Obviously existing -persistent services already deployed can't be changed, but for new ones, it would make sense to use additional volumes from the start

@tobybellwood tobybellwood marked this pull request as ready for review September 17, 2024 04:13
Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobybellwood tobybellwood merged commit 3de4286 into main Sep 17, 2024
3 checks passed
@tobybellwood tobybellwood deleted the docs/221_updates branch September 17, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants