Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable fine-grained github_token permissions #92

Closed
wants to merge 2 commits into from

Conversation

tobybellwood
Copy link
Member

@tobybellwood tobybellwood commented Nov 20, 2024

so...

If we set the fine-grained permissions block (needed to attest images), the GITHUB_TOKEN no longer has the permissions to access organisation-scoped secrets (such as the docker hub credentials shared by all repos) - clue was at https://github.com/orgs/community/discussions/12424

Will keep looking at what we can do to access both organisation-scoped secrets and the attest permissions.

@smlx
Copy link
Member

smlx commented Nov 21, 2024

I think the issue might be dependabot specific. I'm looking into what the fix might be.
dependabot/dependabot-core#3253

@tobybellwood
Copy link
Member Author

@smlx - ha, push and comment at the same time - looks like we just need write-all explicitly set as the permission to allow organization secret and id-token access

@smlx
Copy link
Member

smlx commented Nov 21, 2024

I don't think that's the reason it works now. If you re-add the permissions block and push again I think it will build just as it did in my original PR.

@tobybellwood
Copy link
Member Author

ugh - of course it does 🤦 I'll close this, as I've now added the same vars to dependabot org-scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants