-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken intra-doc links + add CI stage to test example docs #606
Conversation
This reverts commit 563bfeb.
Codecov Report
@@ Coverage Diff @@
## master #606 +/- ##
===========================================
- Coverage 83.75% 68.21% -15.55%
===========================================
Files 156 156
Lines 6969 6969
===========================================
- Hits 5837 4754 -1083
- Misses 1132 2215 +1083
Continue to review full report at Codecov.
|
This reverts commit 0520713.
On my machine the latest I would hold merging this PR until the ICE is fixed. |
The 2021-02-01 nightly includes a fix for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for being so pedantic but simply accept my suggestions and we are good to merge
Co-authored-by: Hero Bird <robin.freyler@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
You can verify for yourself by executing
cargo doc --workspace --document-private-items --verbose --no-deps
inink/
orcargo doc --manifest-path=Cargo.toml --document-private-items --verbose --no-deps
in an example folder.During the issue I discovered a bug in rustdoc.