-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add miri to CI pipeline #401
Conversation
Move miri and coverage to this stage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if it works
@TriplEight https://gitlab.parity.io/parity/ink/-/jobs/519777 any ideas what is causing this? |
Codecov Report
@@ Coverage Diff @@
## master #401 +/- ##
==========================================
+ Coverage 86.27% 86.34% +0.06%
==========================================
Files 131 131
Lines 5727 5727
==========================================
+ Hits 4941 4945 +4
+ Misses 786 782 -4
Continue to review full report at Codecov.
|
there are some issues with |
On hold until we fixed |
Closing this PR since it is heavily outdated. We maybe still want |
Miri is used on CI by quite a few projects, as far as I know. So if you have something that you think needs to happen to make Miri more usable on CI, please let us know by reporting an issue! Right now I am not aware of any major issues. |
We only test
ink_core/storage2
so far.The
miri
tool requiresrust-src
andxargo
tools to be installed.This has been done in a separate PR already.
So far
miri
runs kind of successfully but it doesn't play well withRUST_WRAPPER
andTARGET_DIR
so we have to implement somemiri
specific work arounds here and there to avoid crashing other jobs as can be seen often with theclippy
andtest
jobs.Links: #401 (comment)