Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linter: Warn when number primitive is annotated with #[ink(topic)] #1837

Merged
merged 14 commits into from
Aug 15, 2023
Merged

Linter: Warn when number primitive is annotated with #[ink(topic)] #1837

merged 14 commits into from
Aug 15, 2023

Commits on Jun 26, 2023

  1. The initial structure of the linting crate and tests 

    Nedeed for use-ink#1436
    Georgiy Komarov committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    7ca2cf7 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. Implement the lint that checks primitive types in expanded code

    @jubnzv
    jubnzv committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    574fc18 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. The initial implementation of the primitive_topic lint

    @jubnzv
    jubnzv committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    0938d13 View commit details
    Browse the repository at this point in the history

  2. chore(all): Run clippy

    @jubnzv
    jubnzv committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    173d9ae View commit details
    Browse the repository at this point in the history

  3. fix(fmt)

    @jubnzv
    jubnzv committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    4068abc View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. fix(primitive_topic): Lint suppressions 

    The problem with suppressions is that `rustc` saves the state of the
last visited node and checks its attributes to decide if the lint
warning should be suppressed there (see:
[LateContext::last_node_with_lint_attrs](https://github.com/rust-lang/rust/blob/c44324a4fe8e96f9d6473255df6c3a481caca76f/compiler/rustc_lint/src/context.rs#L1105)).

This commit adds a call to the utility function from clippy that checks
if the lint is suppressed for the field definition node, not for the
last node (which is `Topics` impl).
    @jubnzv
    jubnzv committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    72bb431 View commit details
    Browse the repository at this point in the history

  2. chore: cleanup

    @jubnzv
    jubnzv committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    aa802c3 View commit details
    Browse the repository at this point in the history

  3. chore: make warning messages more consistent

    @jubnzv
    jubnzv committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    6157877 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into 1436-primitive-topic

    @jubnzv
    jubnzv committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    941125a View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2023

  1. feat(lint): support events 2.0 

    Rework the lint after use-ink#1827
    @jubnzv
    jubnzv committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    f10985b View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. chore(all): Fix comments; remove needless empty file

    @jubnzv
    jubnzv committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    a89088b View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. chore(all): Update clippy_utils version

    @jubnzv
    jubnzv committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    3f99ce9 View commit details
    Browse the repository at this point in the history

  2. fix Cargo.toml

    @jubnzv
    jubnzv committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    f66bd95 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Merge remote-tracking branch 'origin/master' into 1436-primitive-topic

    @jubnzv
    jubnzv committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    fe26eaf View commit details
    Browse the repository at this point in the history