Do not include libsecp256k1 on Windows
#1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HCastano
suggested changes
Dec 7, 2021
There was a problem hiding this comment.
So this is the error message a user on Windows would get if they tried to use to_eth_address:
error[E0599]: no method named `to_eth_address` found for struct `ECDSAPublicKey` in the current scope
--> lib.rs:29:28
|
29 | let addr = key.to_eth_address();
| ^^^^^^^^^^^^^^ method not found in `ECDSAPublicKey`
For more information about this error, try `rustc --explain E0599`.
I wonder if we can have a cfg_if check and panic with a better message instead
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
HCastano
approved these changes
Dec 8, 2021
xgreenx
pushed a commit
to Supercolony-net/ink
that referenced
this pull request
Feb 8, 2022
* Do not include `libsecp256k1` on Windows * Apply suggestions from code review Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the broken
cargo-contractWindows CI. See #1068 for more details.CI fails due to expected incompatible ink! with
substrate-contracts-nodesince the deposit PR merge.