Add a lint for missing no_main
#1976
Assignees
Labels
Comments
jubnzv
added
B-feature-request
jubnzv
added a commit
to jubnzv/ink
that referenced
this issue
Nov 11, 2023
jubnzv
added a commit
to jubnzv/cargo-contract
that referenced
this issue
Nov 28, 2023
dylint-based ink! linting rules become mandatory, because we can check ink! compilation errors with them (see use-ink/ink#1976)
jubnzv
added a commit
that referenced
this issue
Nov 28, 2023
* feat(linter): Add `no_main` lint Closes #1976 * feat(lint): Run lint only for onchain compilation targets Otherwise contracts could be built for e2e tests with the `std` feature. * chore(lint): Linting message * chore(lint): Remove the `fail` test All the tests are built locally for the host architecture, therefore the lint is not applied to them. * chore: Add CHANGELOG entry * fix: Remove fail test from Cargo.toml * fix(lint): Comments, lint message * fix(lint): Run `no_main` on e2e tests * fix: fmt * fix: bless tests after fmt fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since use-ink/cargo-contract#1076 we require contracts to be annotated with a
no_mainouter attribute. We added a feature incargo_contractto check for the error use-ink/cargo-contract#1113, but it involves some brittle code to intercept and redirect thestderroutput ofcargo-contractin order to catch the specific error.If it is possible to check for attributes, it would be preferable to do this as a lint.
The text was updated successfully, but these errors were encountered: