Improve error reporting during installation + Release 1.0.1
#469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmichi
commented
Mar 18, 2022
build.rs
Outdated
| dylint_driver_dst_file, | ||
| ); | ||
| let original_name = ink_dylint_driver_dir.join("_Cargo.toml"); | ||
| let original_name = original_name.canonicalize().map_err(|err| { |
There was a problem hiding this comment.
I've also added path-canonicalization here now.
There was a problem hiding this comment.
Why not just canonicalize ink_dylint_driver_dir in the first place, then both original_name and tmp_name will be canonical.
ascjones
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #467, where we don't have an idea what causes it, but the next time someone runs into it we would have better error reporting.