Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable building contract with metadata from another contract #359

Closed
wants to merge 3 commits into from

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Nov 12, 2021

Needed for use-ink/ink#739.

@cmichi cmichi requested a review from ascjones November 12, 2021 16:37
@xgreenx
Copy link
Collaborator

xgreenx commented Nov 12, 2021

I only want to clarify, that this feature is not needed for upgradability=)
Because of the idea of an upgradable contract, that you can change the code at any time, so old ABI can be incorrect, and better to not apply ABI at all for contracts like Proxy.

I think it is better to have some util or command(in cargo-contract) that allows merging several contracts into one ABI file. After, the user can use this ABI file to do a call to the Proxy contract(so he should select the address of the proxy contract and then apply his ABI in UI).

@xgreenx
Copy link
Collaborator

xgreenx commented Nov 13, 2021

Processing metadata from child crates is important in terms of use-ink/ink#809.
So I did an investigation and found the way, how you can collect metadata from crates.
https://github.com/xgreenx/ink-metadata

I created an example of how it can be implemented=) I think it should resolve our problem to generate metadata correct=)

@cmichi
Copy link
Collaborator Author

cmichi commented Nov 17, 2021

I'll close this issue as I used the flag mostly for testing and no longer think it makes sense in master.

@cmichi cmichi closed this Nov 17, 2021
@HCastano HCastano deleted the cmichi-add-ability-to-specify-abi branch July 29, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants