Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update toolchain for ink_linting #1616

Merged
merged 3 commits into from
Apr 25, 2024
Merged

chore: Update toolchain for ink_linting #1616

merged 3 commits into from
Apr 25, 2024

Conversation

jubnzv
Copy link
Member

@jubnzv jubnzv commented Apr 24, 2024 •
edited
Loading

Summary

See: use-ink/ink#2112

  • [n] y/n | Does it introduce breaking changes?
  • [y] y/n | Is it dependent on the specific version of ink or pallet-contracts?

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have added an entry to CHANGELOG.md
  • I have commented my code, particularly in hard-to-understand areas
  • [n/a] I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@jubnzv jubnzv marked this pull request as ready for review April 24, 2024 15:42
cmichi
cmichi reviewed Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@cmichi cmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jubnzv Do we have to notify users of anything? I assume they'll just get an error when trying to lint without the new toolchain?

@jubnzv
Copy link
Member Author

jubnzv commented Apr 24, 2024

@cmichi I think an update in the changelog is enough.

@cmichi cmichi merged commit a5dc570 into use-ink:master Apr 25, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmichi cmichi cmichi approved these changes

@ascjones ascjones Awaiting requested review from ascjones ascjones is a code owner

@smiasojed smiasojed Awaiting requested review from smiasojed smiasojed is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jubnzv @cmichi