Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for cargo build --verifiable --lint command #1512

Merged
merged 13 commits into from
Apr 23, 2024
Merged

Add support for cargo build --verifiable --lint command #1512

merged 13 commits into from
Apr 23, 2024

Conversation

smiasojed
Copy link
Collaborator

@smiasojed smiasojed commented Feb 28, 2024 •
edited
Loading

Summary

Closes #_

  • y/n | Does it introduce breaking changes?
  • y/n | Is it dependent on the specific version of ink or pallet-contracts?

Add linting support in docker image

Description

Fix cargo build --verifiable --lint command

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have added an entry to CHANGELOG.md
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@smiasojed smiasojed marked this pull request as draft February 28, 2024 12:40
@smiasojed smiasojed requested review from jubnzv and removed request for SkymanOne April 11, 2024 10:00
@smiasojed smiasojed marked this pull request as ready for review April 22, 2024 08:55
@smiasojed smiasojed merged commit 255d0ef into master Apr 23, 2024
18 checks passed
@smiasojed smiasojed deleted the sm/docker-lint branch April 23, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones approved these changes

@cmichi cmichi Awaiting requested review from cmichi cmichi is a code owner

@jubnzv jubnzv Awaiting requested review from jubnzv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smiasojed @ascjones