Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve JSON Output for Upload and Remove Commands #1389

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Improve JSON Output for Upload and Remove Commands #1389

merged 3 commits into from
Nov 24, 2023

Commits on Nov 23, 2023

  1. fix: improve JSON output for upload and remove commands 

    This commit addresses an issue where the JSON output for both the upload and remove commands in cargo contract was in an invalid format.

This commit refactors the JSON structure for these commands, resulting in valid JSON objects.

Signed-off-by: Tarek <tareknaser360@gmail.com>
    @tareknaser
    tareknaser committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    e7670d1 View commit details
    Browse the repository at this point in the history

  2. add an entry in CHANGELOG.md for use-ink#1389 

    Signed-off-by: Tarek <tareknaser360@gmail.com>
    @tareknaser
    tareknaser committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    c038776 View commit details
    Browse the repository at this point in the history

  3. fix(cargo-contract): rename removed_code_hash in remove command 

    This commit renames the field removed_code_hash to just code_hash in the remove command output to keep it consistent with between json output and human readable output

Signed-off-by: Tarek <tareknaser360@gmail.com>
    @tareknaser
    tareknaser committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    b156b08 View commit details
    Browse the repository at this point in the history