Add flag -y as a shortcut for --skip-confirm

[AlexD10S]

PR for this issue: Add flag -y that says Yes to every prompt (#1062)

It adds -y as a shortcut for --skip-confirm.
Examplo of use:
cargo contract instantiate --suri //Alice --constructor new --args true -x -y instead of cargo contract instantiate --suri //Alice --constructor new --args true -x --skip-confirm

[ascjones]

As I understood the spec from #1062, this should be a new flag which should skip both --skip-dry-run and --skip-confirm.

[AlexD10S]

As I understood the spec from #1062, this should be a new flag which should skip both --skip-dry-run and --skip-confirm.

My mistake then. I understood it as just a shortcut, but a same logic as the --skip-confirm to skip when prompt the user to confirm the transaction submission.

I am going to modify it to add it as a new flag, that skips both --skip-dry-run and --skip-confirm.

[ascjones]

We should clarify then. @cmichi ?

[cmichi]

Yup, I meant what Andrew said.

[cmichi]

@AlexD10S Don't forget updating the CHANGELOG.md.

[AlexD10S]

Does make sense to have at the same time y with one of the flags skip_confirm or skip_dry_run? I don't see a problem, but in case is better to restrict the use will be done adding conflicts_with.

    /// Before submitting a transaction, do not dry-run it via RPC first.
    #[clap(long, conflicts_with = "y")]
    skip_dry_run: bool,
    /// Before submitting a transaction, do not ask the user for confirmation.
    #[clap(long, conflicts_with = "y")]
    skip_confirm: bool,

[ascjones]

Does make sense to have at the same time y with one of the flags skip_confirm or skip_dry_run? I don't see a problem, but in case is better to restrict the use will be done adding conflicts_with.

    /// Before submitting a transaction, do not dry-run it via RPC first.
    #[clap(long, conflicts_with = "y")]
    skip_dry_run: bool,
    /// Before submitting a transaction, do not ask the user for confirmation.
    #[clap(long, conflicts_with = "y")]
    skip_confirm: bool,

Yes I think it should have conflicts_with

[ascjones]

Sorry for the delay, revisiting this.

After reading the issue again, I believe it incorrectly states that --skip-dry-run is saying yes to a prompt. In fact, what it does is prevent the pre tx submission dry-run which is used for gas estimation. This can be used if the user wants to submit a transaction with their own custom limits, or if the dry-run fails and they want to submit the tx anyway.

Therefore I believe it doesn't make sense to group it with --skip-confirm. It may be true that when manually specifying gas limits the user then wants to skip the confirm step, but I think that is okay to have as a separate option still.

[ascjones]

Possibly we could change this whole PR just by adding y as the short for skip-confirm

[AlexD10S]

No worries, is great to have your feedback.
This was my initial though too. Do you suggest to come back to the initial commit.

[ascjones]

Yes looks good 👍