Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message styling #136

Merged
merged 2 commits into from
Jul 5, 2018
Merged

Conversation

annekainicUSDS
Copy link
Contributor

Description

Connected to usds/us-forms-system-starter-app#9

The problem with error messages being displayed improperly came down to CSS. The reason why "Error" was being displayed before each message was because it was meant to only be read by screenreaders. I needed to add styling (copied from VA's design system) to hide these classes.

In the process of testing things I found another styling issue related to error messages. The date inputs included extra space in an error state, so copied those styles from VA's design system too to collapse that space.

Custom error messages are being displayed properly, so that aspect still works.

Copy link
Contributor

@dmethvin-gov dmethvin-gov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I suppose we're likely to find other missing styles like this in the future? I guess there's no way to know what needs to be copied since CSS is pretty much global.

@annekainicUSDS
Copy link
Contributor Author

Yes, there's a chance there are other missing styles. When I removed references to VA's design system, I didn't want to copy over every stylesheet we were importing before, I tried to only pull in things actually needed. There have been some styles I missed, but I'd rather add them as we find we need them than import more than we need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants