Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Connected to usds/us-forms-system-starter-app#9
The problem with error messages being displayed improperly came down to CSS. The reason why "Error" was being displayed before each message was because it was meant to only be read by screenreaders. I needed to add styling (copied from VA's design system) to hide these classes.
In the process of testing things I found another styling issue related to error messages. The date inputs included extra space in an error state, so copied those styles from VA's design system too to collapse that space.
Custom error messages are being displayed properly, so that aspect still works.