Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intro page issues #160

Closed
fatima-gov opened this issue Jul 12, 2018 · 4 comments
Closed

Intro page issues #160

fatima-gov opened this issue Jul 12, 2018 · 4 comments
Assignees
Labels
[practice] product Product related work [type] documentation Documentation related work

Comments

@fatima-gov
Copy link
Contributor

@bernars-usa @dmethvin-gov let's talk about this as a follow up to #154

Document that intro page and confirmation page are not included in the form itself. If embedding the form in an existing application, these aren’t available.

Cc: @usds/forms-system

@fatima-gov fatima-gov added [practice] product Product related work [type] documentation Documentation related work labels Jul 12, 2018
@fatima-gov fatima-gov added this to the 7/25 Hackathon milestone Jul 12, 2018
@dmethvin-gov
Copy link
Contributor

Also the Intro bug mentioned in the first bullet in #149 . There may be other things on that list that need docs or bug tickets.

@fatima-gov fatima-gov mentioned this issue Jul 12, 2018
32 tasks
@dmethvin-gov
Copy link
Contributor

The intro bug in the starter app was fixed by usds/us-forms-system-starter-app#15 but there is still the original question of whether this should be defined as a standard pages page rather than a React component. That fix to the starter app should actually work regardless, since the current code pushes the special-case intro page onto the routes as /introduction anyway.

@bernars-usa
Copy link
Contributor

Both the intro and review pages are properly documented as described. @dmethvin-gov, do you need to move the information in #160 (comment) into a new issue for your tracking?

@bernars-usa bernars-usa self-assigned this Jul 20, 2018
@dmethvin-gov
Copy link
Contributor

@bernars-usa It's covered by #150 so it looks like this ticket is good to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[practice] product Product related work [type] documentation Documentation related work
Projects
None yet
Development

No branches or pull requests

3 participants