Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link checker to CI #145

Closed
dmethvin-gov opened this issue Jul 10, 2018 · 2 comments · Fixed by #294
Closed

Add link checker to CI #145

dmethvin-gov opened this issue Jul 10, 2018 · 2 comments · Fixed by #294
Assignees
@dmethvin-gov
Labels
[practice] engineering Engineering related work [type] enhancement New feature or request

Comments

@dmethvin-gov
Copy link
Contributor

Per #143 I think we should be able to add https://github.com/tcort/markdown-link-check pretty easily. Rather than make it part of npm run build I'm inclined to just make it part of the CI for PRs and merges to master. When #97 is resolved we'll have a commit hook that runs build to ensure that all the built files are in sync with the source, and I'm concerned that checking all the links on each build would take too long.
@dmethvin-gov dmethvin-gov added [type] enhancement New feature or request [practice] engineering Engineering related work labels Jul 10, 2018
@dmethvin-gov dmethvin-gov self-assigned this Jul 11, 2018
@dmethvin-gov dmethvin-gov mentioned this issue Jul 24, 2018
Merged
@bernars-usa bernars-usa mentioned this issue Jul 25, 2018
Merged
@jcmeloni-usds
Copy link
Contributor

@dmethvin-gov Still a thing, or no?

@dmethvin-gov
Copy link
Contributor Author

Yes, still a thing. If this takes quite a bit of time (it may if we scan all Markdown files) we'd only do this sporadically to avoid the extra work on every commit.

dmethvin-gov added a commit to dmethvin-gov/us-forms-system that referenced this issue Oct 2, 2018
@dmethvin-gov
Use link checker for markdown files, add to lint tasks
485d0c7 
Fixes usds#145

The link checking takes a long time when the file is big or there are
many external links, so I'm only checking the markdown files actually
changed in the commit.
dmethvin-gov added a commit to dmethvin-gov/us-forms-system that referenced this issue Oct 2, 2018
@dmethvin-gov
Use link checker for markdown files, add to lint tasks
c8d783d 
Fixes usds#145

The link checking takes a long time when the file is big or there are
many external links, so I'm only checking the markdown files actually
changed in the commit.
dmethvin-gov added a commit to dmethvin-gov/us-forms-system that referenced this issue Oct 2, 2018
@dmethvin-gov
Use link checker for markdown files, add to lint tasks
4b171ea 
Fixes usds#145

The link checking takes a long time when the file is big or there are
many external links, so I'm only checking the markdown files actually
changed in the commit.
@dmethvin-gov dmethvin-gov mentioned this issue Oct 2, 2018
Merged
9 tasks
dmethvin-gov added a commit that referenced this issue Oct 18, 2018
@dmethvin-gov
Use link checker for markdown files, add to lint tasks (#294)
0327c7d 
Fixes #145

The link checking takes a long time when the file is big or there are
many external links, so I'm only checking the markdown files actually
changed in the commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmethvin-gov dmethvin-gov

Labels
[practice] engineering Engineering related work [type] enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use link checker for markdown files, add to lint tasks dmethvin-gov/us-forms-system
2 participants
@jcmeloni-usds @dmethvin-gov