Merge pull request #8 from CDOT-CV/fix/sdw-failing-tests

Fix failing unit tests
usdot-jpo-ode · Aug 25, 2023 · a169a44 · a169a44
2 parents 410e977 + ebeedcf
commit a169a44
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 23 deletions.
diff --git a/src/test/java/jpo/sdw/depositor/controller/DepositControllerTest.java b/src/test/java/jpo/sdw/depositor/controller/DepositControllerTest.java
@@ -8,10 +8,11 @@
 
 import jpo.sdw.depositor.DepositorProperties;
 import jpo.sdw.depositor.consumerdepositors.KafkaConsumerRestDepositor;
-import mockit.Capturing;
 import mockit.Expectations;
 import mockit.Injectable;
 import mockit.Tested;
+import mockit.Mocked;
+
 
 public class DepositControllerTest {
 
@@ -24,20 +25,22 @@ public class DepositControllerTest {
    @Injectable
    JavaMailSender sender;
 
-   @Capturing
+   @Mocked
    KafkaConsumerFactory capturingKafkaConsumerFactory;
 
-   @Capturing
+   @Mocked
    KafkaConsumerRestDepositor capturingKafkaConsumerRestDepositor;
 
-   @Capturing
+   @Mocked
    URI capturingURI;
 
-   // currently not running, seems to be in endless loop somewhere
-   // @Test
+   @Test
    public void shouldRun() throws URISyntaxException {
+
       new Expectations() {
          {
+            injectableDepositorProperties.getDestinationUrl(); result = "127.0.0.1";
+
             capturingKafkaConsumerRestDepositor.run((String[]) any);
             times = 1;
          }

diff --git a/src/test/java/jpo/sdw/depositor/controller/KafkaConsumerFactoryTest.java b/src/test/java/jpo/sdw/depositor/controller/KafkaConsumerFactoryTest.java
@@ -25,23 +25,23 @@ public class KafkaConsumerFactoryTest {
    @Mocked
    DepositorProperties mockedDepositorProperties;
 
-   // currently failing due to attempt to connect to Kafka broker on creation of consumer
-   // attempted to mock kafka consumer constructor without luck
-   // @Test
-   // public void createConsumerShouldCreateConsumer() {
-   //    new Expectations() {
-   //       {
-   //          // These are required because Properties throws NPE when values are null
-   //          mockedDepositorProperties.getKafkaBrokers();
-   //          result = "kafkaBrokers";
-
-   //          mockedDepositorProperties.getGroupId();
-   //          result = "groupId";
-
-   //       }
-   //    };
-   //    assertNotNull(KafkaConsumerFactory.createConsumer(mockedDepositorProperties));
-   // }
+
+   @Test
+   public void createConsumerShouldCreateConsumer() {
+
+      new Expectations() {
+         {
+            // These are required because Properties throws NPE when values are null
+            mockedDepositorProperties.getKafkaBrokers();
+            result = "kafkaBrokers";
+
+            mockedDepositorProperties.getGroupId();
+            result = "groupId";
+
+         }
+      };
+      assertNotNull(KafkaConsumerFactory.createConsumer(mockedDepositorProperties));
+   }
 
    @Test
    public void testConstructorIsPrivate()