Wrap transformer path with quotes #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since node's `exec` runs the command in a shell, we must quote any arguments we pass to it.
|
Thanks @a3ammar. I made a couple of tweaks: Also I have added you as a collaborator and acknowledged your contribution in You can now update to 5.0.1. |
|
Thanks! I didn't think about windows, good call! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
__dirnamecontained spacesexecwill fail because it runs the command in a shell. A quick fix would be to wrap the__dirnamein single quotes.I don't know Node very well and googling around I couldn't find a builtin safe escaper for command arguments. I think the best way to handle this is to depend on a library that does this, but that is up to you.