Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when AES-NI is not supported by the OS/CPU but supported by the dotnet sdk #515

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Fix error when AES-NI is not supported by the OS/CPU but supported by the dotnet sdk #515

merged 1 commit into from
Nov 27, 2020

Conversation

ycrumeyrolle
Copy link
Collaborator

Resolves #514

@ycrumeyrolle
Copy link
Collaborator Author

Tests confirmed that setting SET COMPlus_EnableAES=0 environment variable raised the PlatformNotSupportedException.
Added also some guard on other AES tests.

@ycrumeyrolle
Copy link
Collaborator Author

AesKeyWrapper was bogus, AesKeyUnwrapper was fine.

@ycrumeyrolle
Copy link
Collaborator Author

Added the static property EncryptionAlgorithm.EnabledAesInstructionSet which is true by default.
Setting to false will switch to non-NI implementation. This produces an acceptable overhead.

@ycrumeyrolle ycrumeyrolle merged commit 38ca800 into master Nov 27, 2020
@ycrumeyrolle ycrumeyrolle deleted the issue514 branch November 27, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Operation is not supported on this platform.
1 participant
@ycrumeyrolle