Rename connection_max_idle_time to max_idle_time

README.md

@@ -110,8 +110,8 @@ These values can be configured as follows (in seconds):
 
 ``` ruby
 Fetch.configure do |config|
-  config.connection_max_idle_time = 10 # default
-  config.keep_alive_timeout       = 2  # default
+  config.max_idle_time      = 10 # default
+  config.keep_alive_timeout = 2  # default
 end
 ```
 

lib/fetch.rb

@@ -10,7 +10,7 @@ def self.configure(&block)
   end
 
   configure do |config|
-    config.connection_max_idle_time = 10
-    config.keep_alive_timeout       = 2
+    config.max_idle_time      = 10
+    config.keep_alive_timeout = 2
   end
 end

lib/fetch/config.rb

@@ -1,3 +1,3 @@
 module Fetch
-  Config = Struct.new(:connection_max_idle_time, :keep_alive_timeout)
+  Config = Struct.new(:max_idle_time, :keep_alive_timeout)
 end

lib/fetch/connection_pool.rb

@@ -72,7 +72,7 @@ def sweep
         @connections.each do |origin, entry|
           next if entry.in_use
 
-          if entry.last_used + Fetch.config.connection_max_idle_time < Time.now
+          if entry.last_used + Fetch.config.max_idle_time < Time.now
             entry.connection.finish
 
             @connections.delete origin

sig/fetch/config.rbs

@@ -1,6 +1,6 @@
 module Fetch
   class Config
-    attr_accessor connection_max_idle_time: Integer
+    attr_accessor max_idle_time: Integer
     attr_accessor keep_alive_timeout: Integer
   end
 end

spec/fetch/connection_pool_spec.rb

@@ -8,7 +8,7 @@
   example 'reusing connections' do
     pool = Fetch::ConnectionPool.new
 
-    Fetch.config.with connection_max_idle_time: 10 do
+    Fetch.config.with max_idle_time: 10 do
       conn1 = pool.with_connection(uri, &:itself)
       conn2 = pool.with_connection(uri, &:itself)
 
@@ -19,7 +19,7 @@
   example 'closing idle connections' do
     pool = Fetch::ConnectionPool.new
 
-    Fetch.config.with connection_max_idle_time: 1 do
+    Fetch.config.with max_idle_time: 1 do
       conn1 = pool.with_connection(uri, &:itself)
       sleep 2
       conn2 = pool.with_connection(uri, &:itself)