Skip to content
This repository has been archived by the owner on Oct 1, 2023. It is now read-only.

Only load items once (reuse promise) #10

Merged
merged 1 commit into from
Jan 19, 2015
Merged

Only load items once (reuse promise) #10

merged 1 commit into from
Jan 19, 2015

Conversation

dougmoscrop
Copy link
Contributor

This fixes #8

I considered using resolve-url to canonicalize the URLs, but did not want to introduce dependency and that can easily be a separate PR if wanted.

I also snuck in a 'build' script so that those of us without Grunt installed -g can just do npm run build.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling bdfab0f on dmoscrop:master into 24d661f on urish:master.

urish added a commit that referenced this pull request Jan 19, 2015
Only load items once (reuse promise)
@urish urish merged commit ce9ce71 into urish:master Jan 19, 2015
@urish
Copy link
Owner

urish commented Jan 19, 2015

Looks good, thanks!

Very nice solution with npm run build instead of having to install Grunt globally.

About resolve-url - how about making the dependency optional?

Uri

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent loading of duplicate resources
3 participants