Skip to content

Commit

Permalink
Submit to CRAN
Browse files Browse the repository at this point in the history
> reduce each example to less than 5 sec
  • Loading branch information
uribo committed Jan 10, 2020
1 parent b468fee commit 0c61af5
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 12 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: zipangu
Title: Japanese Utility Functions and Data
Version: 0.1.0.9000
Version: 0.2.0
Authors@R:
person(given = "Shinya",
family = "Uryu",
Expand Down
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# zipangu (development version)
# zipangu 0.2.0

* Added several functions to handle postal code data.
* `read_zipcode()` to read Japan post's zip-code file and `dl_zipcode_file()` for raw file download.
Expand Down
2 changes: 0 additions & 2 deletions R/jholiday.R
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,6 @@ shubun_day <- function(year) {
#' is_jholiday("2020-01-01")
#' is_jholiday("2018-12-23") # TRUE
#' is_jholiday("2019-12-23") # FALSE
#' is_jholiday("2020-02-23") # TRUE
#' is_jholiday("2020-05-06") # TRUE
#' @export
is_jholiday <- function(date) {
date <-
Expand Down
11 changes: 6 additions & 5 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,18 @@
## Test environments
* local OS X install, R 3.6.1
* ubuntu 16.04.6 (on travis-ci), R 3.6.1
* local OS X install, R 3.6.2
* ubuntu 16.04.6 (on travis-ci), R 3.6.2
* Debian GNU/Linux 9 (on Docker)
* win-builder (devel and release)

## R CMD check results

0 errors | 0 warnings | 2 note
0 errors | 0 warnings | 1 note

* This is a new release.
* Reduced test and example demonstration code to reduce execution time.
* checking data for non-ASCII characters ... found 47 marked UTF-8 strings
* The note refers to mis-spelled words. One of this word is Kanji which used in the Japanese writing system.

```
Possibly mis-spelled words in DESCRIPTION:
Kanji (12:17)
Kanji
```
2 changes: 1 addition & 1 deletion data-raw/japan-holiday.R
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ jholiday_df <-
mutate(date = lubridate::as_date(date)) %>%
tibble::as_tibble()

usethis::use_data(jholiday_df, internal = TRUE)
usethis::use_data(jholiday_df, internal = TRUE, overwrite = TRUE)
2 changes: 0 additions & 2 deletions man/is_jholiday.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 0c61af5

Please sign in to comment.