Exit nonzero on unknown command. Resolves #276. #396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an unknown command is given (iff the app has custom commands at all!) the usage message is printed and we exit with status 3.
|
Hi @danslimmon, thanks for getting the ball rolling on this! This may not cover all of the cases where that help message is printed (specifically for subcommands), but I have an idea for something that might be more generic. I'll follow up with another PR to get your feedback. |
|
Proposed alternate approach in #399 which handles the unknown command under a subcommand case, let me know what you think! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an unknown command is given (iff the app has custom commands at
all!) the usage message is printed and we exit with status 3.