Fix: Shell completions are broken when login shell is different than currently active shell #1884 #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imransolanki
changed the title
imransolanki
changed the title
|
Hey, can you tell us more about how it works? |
The code retrieves env var Example of |
bartekpacia
approved these changes
Aug 21, 2024
|
FWIW, we should look into backporting this to v2 as well. What do you think? |
|
I think this is worth backporting, yeah |
dearchap
approved these changes
Aug 22, 2024
imransolanki
changed the title
|
This actually doesn't fix anything, but breaks printing descriptions in I think this is also a lesson for us, maintainers of this module, to not trust that contributors did actually test their changes. Before this PRScreen.Recording.2024-10-28.at.02.06.53.movAfter this PRScreen.Recording.2024-10-28.at.02.08.49.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This is a fix to bug- Shell completions are broken when login shell is different than currently active shell #1884
$0as an env variable instead ofSHELLas$0gives the currently active shellWhich issue(s) this PR fixes:
Fixes the bug- Shell completions are broken when a login shell is different than currently active shell #1884
Special notes for your reviewer:
Testing
Updated the existing test case.
Release Notes