deps: modernization and upgrades #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fang-
reviewed
Jun 28, 2021
- upgrade: keccak, keythereum, secp256k1, truffle, web3 - remove: react-hot-loader, @hot-loader/react-dom - update README with correct Node version
included changes: - converted some files to Typescript and added typings to aid debugging - reorganized some crypto utilities and constants - added our first test! ... currently being skipped for now (:
Use sha256 instead of keccak256 to ensure 32-byte output for ecdsaSign
- update Development doc - renamings - remove dead code
- update Testing note per fang's feedback
Add context to error message logging Co-authored-by: fang <github@fang.io>
Fang-
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The JS ecosystem moves quickly 🏎️ This PR brings Bridge up-to-date in several crypto libs, and removes unused development libs (since replaced by latest version of
react-scripts). It also seems to resolve the issue we were having with unreliable builds.Changes
Testing
Since there are no automated tests (yet!), we manually tested these changes by following these steps:
rm -rf node_modules/- first, remove existing depsnpm install- reinstall JS packages and rebuild native extensionsnpm run build- generate production-optimized buildnpm run pilot- confirm that local development environment starts successfullyOnce confirming the app was building and loading successfully, we then tested the following flows:
Fixes #410