Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify connectors and junctions schema #261

Merged
merged 2 commits into from
Aug 24, 2023
Merged

modify connectors and junctions schema #261

merged 2 commits into from
Aug 24, 2023

Conversation

tanushree04
Copy link
Contributor

@tanushree04 tanushree04 commented Aug 1, 2023 •
edited
Loading

Resolves #262

Pull Request Description

  • Edits required properties in the schema

Checklist (Delete lines that don't apply)

  • Unit tests have been added or updated
  • Documentation has been modified appropriately
  • All ci tests pass (green)
  • An issue has been created (which will be used for the changelog)
  • This branch is up-to-date with develop

@tanushree04 tanushree04 merged commit 8d1b886 into develop Aug 24, 2023
@tanushree04 tanushree04 deleted the fix_schema branch August 24, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nllong nllong nllong left review comments

@amyeallen1 amyeallen1 amyeallen1 left review comments

@kflemin kflemin kflemin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Thermal Connector and Junction schema lists additional required properties
4 participants
@tanushree04 @nllong @kflemin @amyeallen1