Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for CellTypes when ctypes is missing #151

Merged
merged 2 commits into from
Feb 2, 2016

Conversation

jasonmyers
Copy link
Contributor

Fixes #150 by creating cell objects without the use of ctypes (courtesy of http://nedbatchelder.com/blog/201301/byterun_and_making_cells.html )

@jasonmyers
Copy link
Contributor Author

Just noticed this is not PY3 compatible, working on an updated PR...

@mmckerns
Copy link
Member

mmckerns commented Feb 2, 2016

Doh! This solution has been in dill in the declaration of the CellType object for years. Your PR needs some cleaning to make it pass all the tests, but I will take care of it. Thanks for the patch.

mmckerns added a commit that referenced this pull request Feb 2, 2016
Fix for CellTypes when ctypes is missing
@mmckerns mmckerns merged commit 9af3509 into uqfoundation:master Feb 2, 2016
@jasonmyers
Copy link
Contributor Author

Thanks!

On Feb 1, 2016, at 8:38 PM, Mike McKerns notifications@github.com wrote:

Doh! This solution has been in dill in the declaration of the CellType object for years. Your PR needs some cleaning to make it pass all the tests, but I will take care of it. Thanks for the patch.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants