Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor game loop #183

Merged
merged 16 commits into from
Sep 17, 2024
Merged

Refactor game loop #183

merged 16 commits into from
Sep 17, 2024

Conversation

PalumboN
Copy link
Contributor

@PalumboN PalumboN commented Sep 16, 2024

Fix #181

Es parte de lo que está hecho en #163 (leer descripción), le actualicé a master e hice un toque de refactor

Copy link
Contributor

@fdodino fdodino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sale brillo de ese código!

Copy link
Contributor

@ivojawer ivojawer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheto 💎

Gracias @mind-ar!!

@PalumboN PalumboN merged commit 3bd1433 into master Sep 17, 2024
2 checks passed
@PalumboN PalumboN deleted the refactor-game-loop branch September 17, 2024 23:15
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 39 lines in your changes missing coverage. Please review.

Project coverage is 78.78%. Comparing base (a2a5a0e) to head (50ef88c).
Report is 72 commits behind head on master.

Files with missing lines Patch % Lines
src/commands/run.ts 33.33% 20 Missing ⚠️
src/time-measurer.ts 13.63% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
- Coverage   84.33%   78.78%   -5.55%     
==========================================
  Files           9        8       -1     
  Lines         683      561     -122     
  Branches      162      108      -54     
==========================================
- Hits          576      442     -134     
- Misses        107      119      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

game.clear() cuelga el juego
4 participants