wollok-ts API revamp #129
Merged
wollok-ts API revamp #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
PalumboN
approved these changes
Mar 20, 2024
| import { RuntimeObject } from 'wollok-ts' | ||
| import { Interpreter } from 'wollok-ts/dist/interpreter/interpreter' | ||
| import { Interpreter, RuntimeObject } from 'wollok-ts' |
Comment on lines
+305
to
309
| // TODO WOLLOK-TS: migrate it? Maybe it could be part of Environment | ||
| // Environment.newImportFor(baseNode, importNode) | ||
| function newImport(importNode: Import, environment: Environment) { | ||
| const node = replNode(environment) | ||
| const imported = node.scope.resolve<Package | Entity>(importNode.entity.name)! |
Comment on lines
-9
to
-29
| const LIST_MODULE = 'List' | ||
| const STRING_MODULE = 'wollok.lang.String' | ||
| const WOLLOK_BASE_MODULES = 'wollok.' | ||
|
|
||
| const SELF = 'self' | ||
|
|
||
| function getImportedDefinitions(interpreter: Interpreter, rootFQN?: Package): Entity[] { | ||
| const environment = interpreter.evaluation.environment | ||
| const importedPackage = rootFQN ?? replNode(environment) | ||
| return [ | ||
| ...importedPackage.members, | ||
| ...importedPackage.imports.flatMap(resolveImport), | ||
| ] | ||
| } | ||
|
|
||
| function resolveImport(imp: Import): Entity[] { | ||
| const importedEntity = imp.entity.target! | ||
| return imp.isGeneric | ||
| ? [...(importedEntity as Package).members] | ||
| : [importedEntity] | ||
| } |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #129 +/- ##
==========================================
- Coverage 85.63% 84.91% -0.72%
==========================================
Files 9 9
Lines 696 663 -33
Branches 161 155 -6
==========================================
- Hits 596 563 -33
Misses 100 100 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
El CI no pasa porque necesitamos mergear primero wollok-ts y actualizar el package.json
Qué incluye
wollok-tssin tener que usar las carpetasdistQué hay que mergear antes