Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mssql output support for update or delete query #718

Merged
merged 4 commits into from
Nov 24, 2022
Merged

feat: mssql output support for update or delete query #718

merged 4 commits into from
Nov 24, 2022

Conversation

bgdnxt
Copy link
Contributor

@bgdnxt bgdnxt commented Nov 23, 2022

close #717

@bgdnxt bgdnxt changed the title Add feature.Ouput support for update or delete query WIP Add feature.Ouput support for update or delete query Nov 23, 2022
@bgdnxt
Copy link
Contributor Author

bgdnxt commented Nov 23, 2022

I have checked the err output from CI, which is expected result for the update query changes. should i update the mssql testdata query?

@bgdnxt bgdnxt changed the title WIP Add feature.Ouput support for update or delete query Feat: mssql output support for update or delete query Nov 24, 2022
@bgdnxt bgdnxt changed the title Feat: mssql output support for update or delete query feat: mssql output support for update or delete query Nov 24, 2022
@vmihailenco
Copy link
Member

I have checked the err output from CI, which is expected result for the update query changes. should i update the mssql testdata query?

Yes, assuming the generated query looks good (which it does).

@vmihailenco
Copy link
Member

Looks good, thanks 👍

@vmihailenco vmihailenco merged commit 08876b4 into uptrace:master Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add feature.Ouput support for update or delete query
2 participants
@bgdnxt @vmihailenco