Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #1 by removing integrated caching #2

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

a-bashtannik
Copy link
Contributor

Fix "kid" invalid, unable to lookup correct key error.

Criipto rotates the keys regularly and users get problems with KID values trying to decode the response using cached values.

Support comment:

Each time you receive a JWT with a kid value you haven't seen before, you should fetch new metadata (once).
If the kid is present in the new metadata, you should update your cache and validate the token.
If not, you should reject the JWT.

It means you shall never cache configuration to avoid incosistency.

This PR removes Cache calls.

Fix "kid" invalid, unable to lookup correct key error
@andersmandersen andersmandersen merged commit 02722fa into uptime-development:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants