Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify download/verify subsection #124

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Clarify download/verify subsection #124

merged 1 commit into from
Jul 2, 2019

Conversation

zabbal
Copy link
Contributor

@zabbal zabbal commented Jul 1, 2019

Fixes #121.

Signed-off-by: Max max.suraev@here.com

Signed-off-by: Max <max.suraev@here.com>
@zabbal
Copy link
Contributor Author

zabbal commented Jul 1, 2019

Would be nice to have some native speaker looking over this. Feel free to fix as you see fit.

@iramcdonald
Copy link

iramcdonald commented Jul 1, 2019 via email

@iramcdonald
Copy link

iramcdonald commented Jul 1, 2019 via email

@zabbal
Copy link
Contributor Author

zabbal commented Jul 2, 2019

I'm fine either way - the point is to make it easier for implementors. Whether the clarification is in 1.0 directly or in the issue tracker is a matter of convenience, nothing more :)

@jhdalek55
Copy link
Contributor

This is a very small change so I think we should be able to be incorporate it if someone outside of Max's organization can give it a look. I noticed a small typo in line 724 (it should be "then" instead of "than" because this is sequence of events, rather than comparison.) So that's my grammatical 2 cents, but does anyone have a problem with the change from a technical standpoint?

Thanks.

@iramcdonald
Copy link

iramcdonald commented Jul 2, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify "download and verify images" language
4 participants