Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX-1264: Unify exports #45

Merged
merged 1 commit into from
Oct 1, 2024
Merged

DX-1264: Unify exports #45

merged 1 commit into from
Oct 1, 2024

Conversation

ytkimirti
Copy link
Collaborator

@ytkimirti ytkimirti commented Sep 24, 2024

This PR introduces some small tweaks to unify some parts of our javascript packages. Here are the changes:

  • Updated tsup config
  • Remove unnecessary flag from ci
  • Updated exports field in package.json

I removed all the custom platform exports because they were never used. Since there are "import" and "require" fields, when an import is happening, all other fields are ignored.

 ".": {
      "import": "./dist/nodejs.mjs",
      "require": "./dist/nodejs.js",
      "types": "./dist/nodejs.d.ts",
      ...
}

Here is the before and after output coming from the attw cli:
v before v after

Copy link

linear bot commented Sep 24, 2024

@CahidArda
Copy link
Contributor

can we get the same report as the screenshot from upstash/redis-js#1290?

@CahidArda CahidArda merged commit 04adc06 into master Oct 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants