DX-968: Vector Client for Cloudflare #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogzhanolguncu
previously approved these changes
Jun 7, 2024
CahidArda
previously approved these changes
Jun 7, 2024
fahreddinozcan
dismissed stale reviews from CahidArda and ogzhanolguncu
via
3e5095e
CahidArda
previously approved these changes
Jun 10, 2024
src/platforms/nodejs.ts
Outdated
| env?: { UPSTASH_VECTOR_REST_URL: string; UPSTASH_VECTOR_REST_TOKEN: string }, | ||
| config?: Omit<IndexConfig, "url" | "token"> | ||
| ): Index { | ||
| let url: string | undefined; |
There was a problem hiding this comment.
Maybe just this:
const token = env.UPSTASH_VECTOR_REST_URL ?? process?.env.UPSTASH_VECTOR_REST_UR
if (!token) throw new Error("xxx")
src/platforms/nodejs.ts
Outdated
| token = env.UPSTASH_VECTOR_REST_TOKEN; | ||
| if (!token) { | ||
| throw new Error( | ||
| "Unable to find environment variable: `UPSTASH_VECTOR_REST_TOKEN`. Please add it via `wrangler secret put UPSTASH_VECTOR_REST_TOKEN`" |
There was a problem hiding this comment.
I guess this is a leftover from cloudflare?
ogzhanolguncu
approved these changes
Jun 11, 2024
CahidArda
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.