Improve tests #30
Merged
Improve tests #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was causing some exceptions on the server-side (that are not problematic, just polluting the logs) because it was deleting the namespace right after an insert, in almost the same time as the transient indexing is being done. This was causing us to reject transient indexing operation and log that exception in server's log. This exception is totally safe and can result in normal execution of our APIs, but this test was causing it from time to time. I have modified the test to wait for transient indexing to finish and removed the unnecessary sleep after the namespace is deleted, as the delete namespace operation is visible to the list namespaces operation immediately.
fahreddinozcan
previously approved these changes
May 21, 2024
which are sometimes not awaited
fahreddinozcan
approved these changes
May 21, 2024
|
🫡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the tests by replacing arbitrary sleeps with waiting for indexing to be done, and adding missing awaits to the tests.
See 3dd4102 and 79f6118