Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type of IVennDiagram #53

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Fix type of IVennDiagram #53

merged 1 commit into from
Oct 6, 2024

Conversation

exoego
Copy link

@exoego exoego commented Sep 23, 2024

I am trying to use this library to implement Venn diagram in Mermaid.

This library works finely, but recent TypeScript compilers are complaining type definitions.

TS2345: Argument of type IVennDiagram is not assignable to parameter of type

image

This type issue is resolved if I cast it.
It appears that unknown does not accept any types, while any accepts any types.

@sgratzl sgratzl changed the base branch from main to develop September 29, 2024 18:33
@exoego
Copy link
Author

exoego commented Oct 4, 2024

@sgratzl Sorry, I've rebased to upsetjs:develop

@sgratzl sgratzl merged commit 7fe2f73 into upsetjs:develop Oct 6, 2024
@exoego exoego deleted the fix-type branch October 6, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants